revert: search aria-label (#985)

react-component · Oct 13, 2023 · ebe9e88 · ebe9e88
1 parent d5442ba
commit ebe9e88
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 18 deletions.
diff --git a/src/Selector/Input.tsx b/src/Selector/Input.tsx
@@ -90,7 +90,6 @@ const Input: React.RefForwardingComponent<InputRef, InputProps> = (
     className: classNames(`${prefixCls}-selection-search-input`, inputNode?.props?.className),
 
     role: 'combobox',
-    'aria-label': 'Search',
     'aria-expanded': open || false,
     'aria-haspopup': 'listbox',
     'aria-owns': `${id}_list`,

diff --git a/tests/__snapshots__/Combobox.test.tsx.snap b/tests/__snapshots__/Combobox.test.tsx.snap
@@ -15,7 +15,6 @@ exports[`Select.Combobox renders controlled correctly 1`] = `
         aria-controls="rc_select_TEST_OR_SSR_list"
         aria-expanded="false"
         aria-haspopup="listbox"
-        aria-label="Search"
         aria-owns="rc_select_TEST_OR_SSR_list"
         autocomplete="off"
         class="rc-select-selection-search-input"
@@ -49,7 +48,6 @@ exports[`Select.Combobox renders correctly 1`] = `
         aria-controls="rc_select_TEST_OR_SSR_list"
         aria-expanded="false"
         aria-haspopup="listbox"
-        aria-label="Search"
         aria-owns="rc_select_TEST_OR_SSR_list"
         autocomplete="off"
         class="rc-select-selection-search-input"

diff --git a/tests/__snapshots__/Multiple.test.tsx.snap b/tests/__snapshots__/Multiple.test.tsx.snap
@@ -23,7 +23,6 @@ exports[`Select.Multiple render not display maxTagPlaceholder if maxTagCount not
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"
@@ -144,7 +143,6 @@ exports[`Select.Multiple render truncates tags by maxTagCount and show maxTagPla
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"
@@ -262,7 +260,6 @@ exports[`Select.Multiple render truncates tags by maxTagCount and show maxTagPla
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"
@@ -364,7 +361,6 @@ exports[`Select.Multiple render truncates values by maxTagTextLength 1`] = `
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"

diff --git a/tests/__snapshots__/Select.test.tsx.snap b/tests/__snapshots__/Select.test.tsx.snap
@@ -123,7 +123,6 @@ exports[`Select.Basic no search 1`] = `
         aria-controls="undefined_list"
         aria-expanded="false"
         aria-haspopup="listbox"
-        aria-label="Search"
         aria-owns="undefined_list"
         autocomplete="off"
         class="rc-select-selection-search-input"
@@ -209,7 +208,6 @@ exports[`Select.Basic render renders correctly 1`] = `
         aria-controls="undefined_list"
         aria-expanded="false"
         aria-haspopup="listbox"
-        aria-label="Search"
         aria-owns="undefined_list"
         autocomplete="off"
         class="antd-selection-search-input"
@@ -257,7 +255,6 @@ exports[`Select.Basic render renders data-attributes correctly 1`] = `
         aria-controls="undefined_list"
         aria-expanded="false"
         aria-haspopup="listbox"
-        aria-label="Search"
         aria-owns="undefined_list"
         autocomplete="off"
         class="antd-selection-search-input"
@@ -303,7 +300,6 @@ exports[`Select.Basic render renders disabled select correctly 1`] = `
         aria-controls="undefined_list"
         aria-expanded="false"
         aria-haspopup="listbox"
-        aria-label="Search"
         aria-owns="undefined_list"
         autocomplete="off"
         class="antd-selection-search-input"
@@ -341,7 +337,6 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
         aria-controls="undefined_list"
         aria-expanded="false"
         aria-haspopup="listbox"
-        aria-label="Search"
         aria-owns="undefined_list"
         autocomplete="off"
         class="antd-selection-search-input"

diff --git a/tests/__snapshots__/Tags.test.tsx.snap b/tests/__snapshots__/Tags.test.tsx.snap
@@ -79,7 +79,6 @@ exports[`Select.Tags OptGroup renders correctly 1`] = `
               aria-controls="rc_select_TEST_OR_SSR_list"
               aria-expanded="true"
               aria-haspopup="listbox"
-              aria-label="Search"
               aria-owns="rc_select_TEST_OR_SSR_list"
               autocomplete="off"
               class="rc-select-selection-search-input"
@@ -253,7 +252,6 @@ exports[`Select.Tags render not display maxTagPlaceholder if maxTagCount not rea
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"
@@ -371,7 +369,6 @@ exports[`Select.Tags render truncates tags by maxTagCount and show maxTagPlaceho
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"
@@ -486,7 +483,6 @@ exports[`Select.Tags render truncates tags by maxTagCount and show maxTagPlaceho
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"
@@ -585,7 +581,6 @@ exports[`Select.Tags render truncates values by maxTagTextLength 1`] = `
             aria-controls="rc_select_TEST_OR_SSR_list"
             aria-expanded="false"
             aria-haspopup="listbox"
-            aria-label="Search"
             aria-owns="rc_select_TEST_OR_SSR_list"
             autocomplete="off"
             class="rc-select-selection-search-input"

diff --git a/tests/__snapshots__/ssr.test.tsx.snap b/tests/__snapshots__/ssr.test.tsx.snap
@@ -1,3 +1,3 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-selector"><span class="rc-select-selection-search"><input type="search" autoComplete="off" class="rc-select-selection-search-input" role="combobox" aria-label="Search" aria-expanded="false" aria-haspopup="listbox" aria-owns="undefined_list" aria-autocomplete="list" aria-controls="undefined_list" value="" readonly="" unselectable="on" style="opacity:0"/></span><span class="rc-select-selection-placeholder"></span></div></div>"`;
+exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-selector"><span class="rc-select-selection-search"><input type="search" autoComplete="off" class="rc-select-selection-search-input" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-owns="undefined_list" aria-autocomplete="list" aria-controls="undefined_list" value="" readonly="" unselectable="on" style="opacity:0"/></span><span class="rc-select-selection-placeholder"></span></div></div>"`;