Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passThrough onKeyDown of Custom Input #175

Merged
merged 1 commit into from
Apr 2, 2017
Merged

passThrough onKeyDown of Custom Input #175

merged 1 commit into from
Apr 2, 2017

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Apr 1, 2017

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 95.719% when pulling b14b045 on RaoHai:passthroughOnKeyDown into 712d960 on react-component:master.

@yesmeck yesmeck merged commit 5e1686c into react-component:master Apr 2, 2017
benjycui
benjycui reviewed Apr 5, 2017
View reviewed changes
src/Select.jsx
@@ -28,6 +28,16 @@ function saveRef(name, component) {
this[name] = component;
}

function chaining(...fns) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数在 rc-util 已经存在，直接引用即可 https://github.com/react-component/util/blob/master/src/createChainedFunction.js

重构一下？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjycui benjycui benjycui left review comments

Assignees

@yesmeck yesmeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't add onKeyDown event listener with the AutoComplete Customize Input Component
4 participants
@RaoHai @coveralls @benjycui @yesmeck