Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit to the amount of selected tags shown #193

Merged
merged 2 commits into from Oct 27, 2017

Conversation

pindamonhangaba
Copy link
Contributor

When having to select more than 100 options, all those tags become a performance issue. It's better to be able to treat the Select as a normal multiple select input, limiting the amount of selected tags:

image

@afc163 afc163 requested a review from yiminghe May 22, 2017 12:54
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 96.063% when pulling fec5aab on pindamonhangaba:master into ded6a52 on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 96.063% when pulling 1caa38d on pindamonhangaba:master into ded6a52 on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 96.063% when pulling 1caa38d on pindamonhangaba:master into ded6a52 on react-component:master.

@yesmeck
Copy link
Member

yesmeck commented Jun 5, 2017

Hello @pindamonhangaba , could you write some tests for this feature, thanks!

@Kamahl19
Copy link

It would be great to see this feature merged

@iuri-gg
Copy link
Contributor

iuri-gg commented Sep 12, 2017

@yesmeck @yiminghe @afc163 PR #224 has tests and example for this change. can we take it in?

@yesmeck yesmeck merged commit 1caa38d into react-component:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants