Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance, don't read offsetWidth when popup is not shown #455

Merged
merged 2 commits into from Feb 4, 2020
Merged

Conversation

rinick
Copy link
Contributor

@rinick rinick commented Feb 4, 2020

This fix a performance issue when components are update asynchronously

resolves: ant-design/ant-design#21210

@vercel
Copy link

vercel bot commented Feb 4, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/select/mq6d2n6j2
✅ Preview: https://select-git-fork-rinick-master.react-component.now.sh

@zombieJ zombieJ merged commit b76b4bd into react-component:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select shouldn't always read container's offsetWidth in useLayoutEffect
3 participants