fix: wrappig index param #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/select/AMfNenaXNPQDwpjaS7fHqLVeVXDk |
nieyuyao
force-pushed
the
fix/scrollIntoView-params
branch
from
3d1e130
to
b7bcf12
Compare
|
来个用例。 |
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 25 25
Lines 1013 1013
Branches 320 321 +1
=======================================
Hits 1008 1008
Misses 4 4
Partials 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
是 https://github.com/react-component/select/pull/728/files#diff-72ec48c7788c5c428904bee5501e48f2f6ddcd678eb89dc03788715c14452860R71 这里改出来的问题。最好这里直接加个判断： listRef.current.scrollTo(typeof args === 'number' ? { index: args } : args); |
afc163
referenced
this pull request
Apr 13, 2022
* Fix: fix scroll params [issue-link](ant-design/ant-design#34468) * Chore: add unit test for scroll config type params
|
scrollIntoView 几处调用就不动了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ant-design/ant-design#34898
fix: ant-design/ant-design#35022