Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select label React Node warning some case #961

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Wxh16144
Copy link

  • fix: Select label React Node warning some case

  • test: test driven

  • fix: warning of label when update

  • chore: clean up

  • chore: back of raw


Co-authored-by: 洋 hetongyang@bytedance.com
Co-authored-by: 二货机器人 smith3816@gmail.com
(cherry picked from commit a5d4b75)

Conflicts:

src/Select.tsx

background: ant-design/ant-design#43637 (comment)

@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ❌ Failed (Inspect) Jul 21, 2023 11:06am

@afc163
Copy link
Member

afc163 commented Jul 19, 2023

ci 怎么没了

@Wxh16144
Copy link
Author

Wxh16144 commented Jul 19, 2023

* fix: Select label React Node warning some case

* test: test driven

* fix: warning of label when update

* chore: clean up

* chore: back of raw

---------

Co-authored-by: 洋 <hetongyang@bytedance.com>
Co-authored-by: 二货机器人 <smith3816@gmail.com>
(cherry picked from commit a5d4b75)

# Conflicts:
#	src/Select.tsx
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #961 (eaf475d) into 14.1.x (0235c7f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head eaf475d differs from pull request most recent head 581a9ce. Consider uploading reports for the commit 581a9ce to get more accurate results

@@           Coverage Diff           @@
##           14.1.x     #961   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          37       37           
  Lines        1341     1345    +4     
  Branches      358      362    +4     
=======================================
+ Hits         1336     1340    +4     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/Select.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MadCcc MadCcc merged commit 305b3dc into react-component:14.1.x Jul 21, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants