Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: search aria-label #985

Merged
merged 1 commit into from Oct 13, 2023
Merged

revert: search aria-label #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Selector/Input.tsx
View file
Open in desktop
Expand Up @@ -90,7 +90,6 @@ const Input: React.RefForwardingComponent<InputRef, InputProps> = (
className: classNames(`${prefixCls}-selection-search-input`, inputNode?.props?.className),

role: 'combobox',
'aria-label': 'Search',
'aria-expanded': open || false,
'aria-haspopup': 'listbox',
'aria-owns': `${id}_list`,
Expand Down
2 changes: 0 additions & 2 deletions tests/__snapshots__/Combobox.test.tsx.snap
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@ exports[`Select.Combobox renders controlled correctly 1`] = `
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -49,7 +48,6 @@ exports[`Select.Combobox renders correctly 1`] = `
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down
4 changes: 0 additions & 4 deletions tests/__snapshots__/Multiple.test.tsx.snap
View file
Open in desktop
Expand Up @@ -23,7 +23,6 @@ exports[`Select.Multiple render not display maxTagPlaceholder if maxTagCount not
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -144,7 +143,6 @@ exports[`Select.Multiple render truncates tags by maxTagCount and show maxTagPla
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -262,7 +260,6 @@ exports[`Select.Multiple render truncates tags by maxTagCount and show maxTagPla
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -364,7 +361,6 @@ exports[`Select.Multiple render truncates values by maxTagTextLength 1`] = `
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down
5 changes: 0 additions & 5 deletions tests/__snapshots__/Select.test.tsx.snap
View file
Open in desktop
Expand Up @@ -123,7 +123,6 @@ exports[`Select.Basic no search 1`] = `
aria-controls="undefined_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="undefined_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -209,7 +208,6 @@ exports[`Select.Basic render renders correctly 1`] = `
aria-controls="undefined_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="undefined_list"
autocomplete="off"
class="antd-selection-search-input"
Expand Down Expand Up @@ -257,7 +255,6 @@ exports[`Select.Basic render renders data-attributes correctly 1`] = `
aria-controls="undefined_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="undefined_list"
autocomplete="off"
class="antd-selection-search-input"
Expand Down Expand Up @@ -303,7 +300,6 @@ exports[`Select.Basic render renders disabled select correctly 1`] = `
aria-controls="undefined_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="undefined_list"
autocomplete="off"
class="antd-selection-search-input"
Expand Down Expand Up @@ -341,7 +337,6 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
aria-controls="undefined_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="undefined_list"
autocomplete="off"
class="antd-selection-search-input"
Expand Down
5 changes: 0 additions & 5 deletions tests/__snapshots__/Tags.test.tsx.snap
View file
Open in desktop
Expand Up @@ -79,7 +79,6 @@ exports[`Select.Tags OptGroup renders correctly 1`] = `
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="true"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -253,7 +252,6 @@ exports[`Select.Tags render not display maxTagPlaceholder if maxTagCount not rea
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -371,7 +369,6 @@ exports[`Select.Tags render truncates tags by maxTagCount and show maxTagPlaceho
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -486,7 +483,6 @@ exports[`Select.Tags render truncates tags by maxTagCount and show maxTagPlaceho
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down Expand Up @@ -585,7 +581,6 @@ exports[`Select.Tags render truncates values by maxTagTextLength 1`] = `
aria-controls="rc_select_TEST_OR_SSR_list"
aria-expanded="false"
aria-haspopup="listbox"
aria-label="Search"
aria-owns="rc_select_TEST_OR_SSR_list"
autocomplete="off"
class="rc-select-selection-search-input"
Expand Down
2 changes: 1 addition & 1 deletion tests/__snapshots__/ssr.test.tsx.snap
View file
Open in desktop
@@ -1,3 +1,3 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-selector"><span class="rc-select-selection-search"><input type="search" autoComplete="off" class="rc-select-selection-search-input" role="combobox" aria-label="Search" aria-expanded="false" aria-haspopup="listbox" aria-owns="undefined_list" aria-autocomplete="list" aria-controls="undefined_list" value="" readonly="" unselectable="on" style="opacity:0"/></span><span class="rc-select-selection-placeholder"></span></div></div>"`;
exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-selector"><span class="rc-select-selection-search"><input type="search" autoComplete="off" class="rc-select-selection-search-input" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-owns="undefined_list" aria-autocomplete="list" aria-controls="undefined_list" value="" readonly="" unselectable="on" style="opacity:0"/></span><span class="rc-select-selection-placeholder"></span></div></div>"`;