fix: onAfterChange should called with number if not range (#824)

react-component · Mar 24, 2022 · 9332abe · 9332abe · vercel · Mar 24, 2022
1 parent a05295d
commit 9332abe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Slider.tsx b/src/Slider.tsx
@@ -299,7 +299,7 @@ const Slider = React.forwardRef((props: SliderProps, ref: React.Ref<SliderRef>)
       }
 
       triggerChange(cloneNextValues);
-      onAfterChange?.(cloneNextValues);
+      onAfterChange?.(getTriggerValue(cloneNextValues));
     }
   };
 

diff --git a/tests/Slider.test.js b/tests/Slider.test.js
@@ -580,4 +580,13 @@ describe('Slider', () => {
     fireEvent.keyDown(container.querySelector('.rc-slider-handle'), { keyCode: keyCode.RIGHT });
     expect(onChange).toHaveBeenCalledWith(0.82);
   });
+
+  it('onAfterChange should return number', () => {
+    const onAfterChange = jest.fn();
+    const { container } = render(<Slider onAfterChange={onAfterChange} />);
+    fireEvent.mouseDown(container.querySelector('.rc-slider'), {
+      clientX: 20,
+    });
+    expect(onAfterChange).toHaveBeenCalledWith(20);
+  });
 });