Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip formatter #32

Closed
thorbenziemek opened this issue Nov 5, 2015 · 6 comments
Closed

Tooltip formatter #32

thorbenziemek opened this issue Nov 5, 2015 · 6 comments

Comments

@thorbenziemek
Copy link

It would be nice to be able to format the tooltip's contents.

thorbenziemek added a commit to thorbenziemek/slider that referenced this issue Nov 5, 2015
@coniel
Copy link

coniel commented Nov 13, 2015

Also, it would be nice to be able to disable the tooltip.

@benjycui
Copy link
Member

@coniel do you mean that rc-slider should provide a prop to hide tooltip?

@coniel
Copy link

coniel commented Nov 14, 2015

@benjycui Yep, basically just expose the noTip prop on the Handle up to the Slider component.

@just-boris
Copy link
Contributor

@coniel @benjycui I have a better solution. How about prop like handleComponent? By default, the bundled Handle component will be used, but it would be possible to replace entire handle to different implementation.

It is makes sense for me, because I need to create slider with the following view:

image

Now I can do it only by patching this lib, but then I can configure handle view via configuration prop and it makes possible to create any design of slider.

@benjycui
Copy link
Member

@just-boris It is reasonable. What is your opinio? @yiminghe @simaQ

@coniel Next time, you should open a new issue to discuss a new feature. It is weirdo to discuss two different features in one issue. Though they are relative.

@yiminghe
Copy link
Member

ok with tipFormatter

jspyhotdev pushed a commit to jspyhotdev/React-slider that referenced this issue Jul 13, 2018
Senior-Hayato-Suzuki pushed a commit to Senior-Hayato-Suzuki/react-slider that referenced this issue Feb 16, 2020
Senior-Hayato-Suzuki pushed a commit to Senior-Hayato-Suzuki/react-slider that referenced this issue Feb 26, 2020
blue-git-pro added a commit to blue-git-pro/dashboard-next.js that referenced this issue May 14, 2021
web3gru pushed a commit to web3gru/slider that referenced this issue May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants