feature: support minimumTrackTintColor & maximumTrackTintColor #243
Conversation
silentcloud
force-pushed
the
support-color
branch
from
49396c2
to
5b2a9b0
Compare
README.md
Outdated
| @@ -105,6 +105,8 @@ The following APIs are shared by Slider and Range. | |||
| | onBeforeChange | Function | NOOP | `onBeforeChange` will be triggered when `ontouchstart` or `onmousedown` is triggered. | | |||
| | onChange | Function | NOOP | `onChange` will be triggered while the value of Slider changing. | | |||
| | onAfterChange | Function | NOOP | `onAfterChange` will be triggered when `ontouchend` or `onmouseup` is triggered. | | |||
| | minimumTrackTintColor | String | #e9e9e9 | The color used for the track to the left of the button. | | |||
There was a problem hiding this comment.
@silentcloud 把这个默认值体现在 defaultProps 里面吧，放到css里面写死，后面维护性不是很好
There was a problem hiding this comment.
@paranoidjk 不放在 defaultProps 里的原因是：用户可以直接通过 theme 来定义，而不用传这个参数，react-tiny 里没办法定义 theme，所以需要这两个 prop
There was a problem hiding this comment.
没get到你的意思，在react-component这层它是没有theme的概念的，直接用props当配置项
There was a problem hiding this comment.
在antd-mobile那层同时保留theme和props就行，props定义可以覆盖theme
There was a problem hiding this comment.
@paranoidjk 意思就是说，要 theme 的优先级高于 prop，用户优先以全局 theme 来定义 color
There was a problem hiding this comment.
因为代码里用的 style，传了 defaultProps 之后，style 的 color 优先级就高了，theme 就没作用了
There was a problem hiding this comment.
因为代码里用的 style，传了 defaultProps 之后，style 的 color 优先级就高了，theme 就没作用了
发个代码链接我看下？
There was a problem hiding this comment.
还是没理清楚你这个需求的背景，按我的理解，antd-mobile是基于rc-component, react-tiny不是在antd-mobile之上的吗？ 为啥在rc-sider这层还要纠结于theme的处理，rc-slider就只有props才对
|
@silentcloud 6.3.0 |
|
ok |
ant-design/ant-design-mobile#1024
for react-tiny