ensure onBeforeChange is called when clicking the rail #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/slider/5jZT5v67WDJQ9GRXeqAr2HHLDCiW |
This was referenced Mar 21, 2022
|
Test case is needed |
zombieJ
reviewed
Apr 12, 2022
tests/Slider.test.js
Outdated
| @@ -489,13 +489,23 @@ describe('Slider', () => { | |||
|
|
|||
| describe('click slider to change value', () => { | |||
| it('ltr', () => { | |||
| const onBeforeChange = jest.fn(); | |||
There was a problem hiding this comment.
Could you help create a new test case instead of modify current one?
|
CI broken |
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 13 13
Lines 532 533 +1
Branches 135 135
=======================================
+ Hits 531 532 +1
Misses 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 10.0.0-alpha.5, when you click the rail, the following events are fired:
onChange,onAfterChange. This PR ensures thatonBeforeChangewill be fired as well.Background: there has historically been some bugginess around which events are fired when clicking on the rail. In version 8.6.1, we correctly fired all three:
onBeforeChange,onChange,onAfterChange.In version 9.7.5, we fired too many events when clicking on the rail:
onBeforeChange,onChange,onBeforeChange,onAfterChange.See this issue for more people that have been affected by these event firing inconsistencies: #492