Update Switch to use new style classes. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
rebase master |
|
Hmm it looks like it's an old version of node, should I upgrade the node version to 6? Edit: Nevermind, you did that. |
Pinned xtemplate to 4.6.0 since 4.7.x is broken at the moment.
dispalt
force-pushed
the
feature/migrate-to-class
branch
from
b4483e0
to
78b5a9a
Compare
|
So I am not really sure how this ever passed. I could probably fix the lint issues, but the other tests, I am not entirely sure... Any tips? |
|
rebase master, I just updated it in master. |
|
I did rebase, but I don't know how to fix the tests. I could probably fix linting. I did not update the version number. |
|
Try |
|
I ran that, it failed, but it could have never worked before. It fails on the example which I never touched. |
|
I correct it and bump a new |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also had to pin
xtemplateto4.6.0since4.7.xis broken at the moment.