Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child of <Tab> can be null #31

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Conversation

zetoke
Copy link
Contributor

@zetoke zetoke commented Sep 25, 2016

Hello!
I have some use cases, when children of may be null.
For example:
{ this.state.haveAccessForTab ? <TabPane></TabPane> : null
Does my changes break anything?
I would be very grateful if these changes go to the upstream.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 76.264% when pulling bd70827 on zetoke:null_children into b248794 on react-component:master.

@yiminghe yiminghe merged commit 89c7c9c into react-component:master Sep 26, 2016
@zetoke
Copy link
Contributor Author

zetoke commented Sep 26, 2016

@yiminghe thanks for your additional changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants