Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add animatedWithMargin to work with positon fixed #45

Merged
merged 1 commit into from
Dec 6, 2016
Merged

feat: add animatedWithMargin to work with positon fixed #45

merged 1 commit into from
Dec 6, 2016

Conversation

benjycui
Copy link
Member

@benjycui benjycui commented Dec 6, 2016 •
edited
Loading

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 75.0% when pulling 13d4095 on refactor-animation into 6b895e1 on master.

@benjycui
Copy link
Member Author

benjycui commented Dec 6, 2016

不知道最初用 transform 的动机是什么，已经重构了 TabContent，如果没问题的话，SwipeableTabContent 也可以用同样的方式重构？

@yiminghe
Copy link
Member

yiminghe commented Dec 6, 2016

transform 性能好啊，特别在移动端

@benjycui benjycui changed the title [WIP] refactor: implement animation with margin feat: add animatedWithMargin to work with positon fixed Dec 6, 2016
@benjycui
Copy link
Member Author

benjycui commented Dec 6, 2016

Done.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 75.229% when pulling d8c68a7 on refactor-animation into 6b895e1 on master.

@yiminghe yiminghe merged commit 6524ddf into master Dec 6, 2016
@yiminghe yiminghe deleted the refactor-animation branch December 6, 2016 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yiminghe yiminghe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjycui @coveralls @yiminghe