feat: add swipeableTabBar for antd-mobile #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paranoidjk
force-pushed
the
feat/swipeableTabBar
branch
from
a97376f
to
235bd50
Compare
|
Changes Unknown when pulling a97376f on feat/swipeableTabBar into ** on master**. |
paranoidjk
force-pushed
the
feat/swipeableTabBar
branch
from
235bd50
to
9c8223c
Compare
4 tasks
|
Changes Unknown when pulling 9c8223c on feat/swipeableTabBar into ** on master**. |
|
@afc163 有时间帮忙看下，没问题的话需要这边合了发个版本 ant-design/ant-design-mobile#882 npm owner ls rc-tabs
afc163 <afc163@gmail.com>
dxq613 <dxq613@gmail.com>
yiminghe <yiminghe@gmail.com> |
afc163
reviewed
Feb 28, 2017
| @@ -26,6 +26,12 @@ | |||
| height: 99999px; | |||
| } | |||
|
|
|||
| &-right &-nav-swipe { | |||
There was a problem hiding this comment.
- 样式还是不合并了，参考上面一行scrollTabBar的样式，也是分四个position写在4个文件里的，好维护
- 用例我来补下吧
|
补下用例吧。 |
paranoidjk
force-pushed
the
feat/swipeableTabBar
branch
from
9c8223c
to
b56f035
Compare
paranoidjk
changed the title
paranoidjk
force-pushed
the
feat/swipeableTabBar
branch
from
b56f035
to
e7eaf17
Compare
|
Changes Unknown when pulling e7eaf17 on feat/swipeableTabBar into ** on master**. |
paranoidjk
force-pushed
the
feat/swipeableTabBar
branch
from
e7eaf17
to
c5f1e74
Compare
|
Changes Unknown when pulling c5f1e74 on feat/swipeableTabBar into ** on master**. |
paranoidjk
changed the title
|
ping @afc163 done. test只加了基础功能，滑动过程涉及getComputedStyle比较难测就没写，但在ant-design/ant-design-mobile#882 这边实测没问题了 |
paranoidjk
added a commit
to ant-design/ant-design-mobile
that referenced
this pull request
Mar 2, 2017
paranoidjk
force-pushed
the
feat/swipeableTabBar
branch
from
08a25e0
to
759a282
Compare
|
Changes Unknown when pulling 759a282 on feat/swipeableTabBar into ** on master**. |
|
@afc163 npm owner 加下我也可以 |
|
|
已经release 7.2.0, demo在这 http://react-component.github.io/tabs/examples/swipeInkTabBar.html |
paranoidjk
added a commit
to ant-design/ant-design-mobile
that referenced
this pull request
Mar 2, 2017
paranoidjk
added a commit
to ant-design/ant-design-mobile
that referenced
this pull request
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:
gitlab/react-ui/ant-mobile/issues/404设计师需求：
其他feature：
swipeableTabContent结合使用antd-mobile 封装demo： https://github.com/ant-design/ant-design-mobile/pull/882/files
close ant-design/ant-design-mobile#394