feat: add overflow trigger props #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
afc163
reviewed
Mar 27, 2024
src/TabNavList/OperationNode.tsx
Outdated
| @@ -37,6 +38,7 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop | |||
| locale, | |||
| mobile, | |||
| moreIcon = 'More', | |||
| moreTrigger = 'hover', | |||
| moreTransitionName, | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
will Check it out later.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 18 18
Lines 702 703 +1
Branches 192 200 +8
=======================================
+ Hits 686 687 +1
Misses 16 16 ☔ View full report in Codecov by Sentry. |
afc163
reviewed
Mar 27, 2024
src/TabNavList/OperationNode.tsx
Outdated
| @@ -18,8 +18,7 @@ export interface OperationNodeProps { | |||
| tabBarGutter?: number; | |||
| activeKey: string; | |||
| mobile: boolean; | |||
| moreIcon?: React.ReactNode; | |||
| moreTrigger?: moreTrigger; | |||
| more?: more | |||
There was a problem hiding this comment.
Suggested change
| more?: more | |
| more?: MoreProps; |
afc163
reviewed
Mar 27, 2024
src/interface.ts
Outdated
Comment on lines
8
to
11
| export type more = { | ||
| moreTrigger?: moreTrigger, | ||
| moreIcon?: moreIcon, | ||
| } |
There was a problem hiding this comment.
Suggested change
| export type more = { | |
| moreTrigger?: moreTrigger, | |
| moreIcon?: moreIcon, | |
| } | |
| export type MoreProps = { | |
| icon?: moreIcon, | |
| } & TriggerProps; |
There was a problem hiding this comment.
这里为什么用 & TriggerProps;这样的写法
afc163
reviewed
Mar 28, 2024
src/TabNavList/OperationNode.tsx
Outdated
| @@ -36,7 +36,7 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop | |||
| tabs, | |||
| locale, | |||
| mobile, | |||
| moreIcon = 'More', | |||
| more: moreProp = {}, | |||
There was a problem hiding this comment.
Suggested change
| more: moreProp = {}, | |
| more: moreProps = {}, |
afc163
reviewed
Mar 28, 2024
src/TabNavList/OperationNode.tsx
Outdated
| @@ -52,6 +52,8 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop | |||
| const [open, setOpen] = useState(false); | |||
| const [selectedKey, setSelectedKey] = useState<string>(null); | |||
|
|
|||
| const { icon: moreIcon = 'More', trigger = 'hover' } = moreProp; | |||
There was a problem hiding this comment.
把 moreProps 放到 Dropdown 的属性最下面去，这个可以支持 DropdownProps 所有能力。
<Dropdown
...
...
...
{...moreProps}
>
afc163
reviewed
Mar 28, 2024
src/interface.ts
Outdated
| export type moreIcon = React.ReactNode; | ||
| export type MoreProps = { | ||
| icon?: moreIcon, | ||
| } & TriggerProps ; |
There was a problem hiding this comment.
Suggested change
| } & TriggerProps ; | |
| } & DropdownProps ; |
afc163
reviewed
Mar 28, 2024
src/TabNavList/OperationNode.tsx
Outdated
| @@ -36,7 +36,7 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop | |||
| tabs, | |||
| locale, | |||
| mobile, | |||
| moreIcon = 'More', | |||
| more: moreProps = {}, | |||
| moreTransitionName, | |||
There was a problem hiding this comment.
moreTransitionName 也可以干掉，改用 more={{ transitionName }} 支持。
afc163
reviewed
Mar 29, 2024
src/interface.ts
Outdated
| @@ -10,6 +10,7 @@ export type TriggerProps = { | |||
| export type moreIcon = React.ReactNode; | |||
| export type MoreProps = { | |||
| icon?: moreIcon, | |||
| transitionName?: string, | |||
There was a problem hiding this comment.
DropdownProps 应该有 transitionName ？
afc163
reviewed
Mar 29, 2024
src/TabNavList/OperationNode.tsx
Outdated
| @@ -18,8 +18,7 @@ export interface OperationNodeProps { | |||
| tabBarGutter?: number; | |||
| activeKey: string; | |||
| mobile: boolean; | |||
| moreIcon?: React.ReactNode; | |||
| moreTransitionName?: string; | |||
| more?: MoreProps | |||
There was a problem hiding this comment.
Suggested change
| more?: MoreProps | |
| more?: MoreProps; |
Check that. |
prepare merge |
|
@afc163 check have passed |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref：ant-design/ant-design#44858
add a new props to control overflow trigger way
In the tabs component, currently we only have hover functionality for triggering the overflow. However, some scenarios require a click action.