feat: Add class name for the input element #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 7 7
Lines 383 383
Branches 95 95
=======================================
Hits 349 349
Misses 34 34
Continue to review full report at Codecov.
|
|
This is what i'm looking for. Can we please merge this in? |
|
Think there's broken test with the extra spacing in the classname. Would you mind fixing it @Amwam. Thanks |
|
@jcleefw Thanks, I've updated to fix the tests |
Amwam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the addition of a custom class to the input element
The typescript definitions we also failing to pass the lint (and were possibly a TS v1 definition?), so I've imported from Definitely Typed, and updated.