Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Auto-position arrow #166

Closed
wants to merge 11 commits into from
Closed

feat: Auto-position arrow #166

wants to merge 11 commits into from

Conversation

sooth-sayer
Copy link

No description provided.

@BenjaminEckardt BenjaminEckardt mentioned this pull request Feb 19, 2019
Open
@bedakb bedakb mentioned this pull request Feb 20, 2019
Open
bedakb
bedakb reviewed Mar 7, 2019
View reviewed changes
src/Tooltip.jsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented May 8, 2019

@zombieJ look this

@zombieJ
Copy link
Member

zombieJ commented May 9, 2019

Could you help to add a reproduce to tell which case is handle for?

@afc163
Copy link
Member

afc163 commented May 9, 2019

#161
#54

zombieJ
zombieJ reviewed May 13, 2019
View reviewed changes
src/Tooltip.jsx Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed May 17, 2019
View reviewed changes
src/Tooltip.jsx Outdated Show resolved Hide resolved
@sooth-sayer sooth-sayer changed the title Auto-position arrow feat: Auto-position arrow May 17, 2019
@Smeky
Copy link

Smeky commented Jul 2, 2019

@zombieJ Any update on this? Fixes a certain issue for me, so would like it to get merged soon.

@afc163
Copy link
Member

afc163 commented Jul 2, 2019

LGTM

@zombieJ
Copy link
Member

zombieJ commented Jul 2, 2019 •
edited

Sorry for delay. The first time render by changing I found miss the animation. Could you help check on this?
Kapture 2019-07-02 at 18 24 56

@bedakb
Copy link

bedakb commented Sep 2, 2019

@zombieJ any update on this one ? I could have look into that animation issue.

@zombieJ
Copy link
Member

zombieJ commented Sep 3, 2019

@bedakb , welcome : )

@sooth-sayer
Copy link
Author

i think that it's related to react-component/animate#38. It's fixed but available only in 3.0.0 :(

@zombieJ
Copy link
Member

zombieJ commented Oct 2, 2019

@sooth-sayer , will update rc-trigger with CSSMotion in rc-animate instead of Animate since 4.0 will warning for componentWillReceiveProps. You can wait this : )

@sooth-sayer
Copy link
Author

@zombieJ Ok, will wait :)

@alicewriteswrongs alicewriteswrongs mentioned this pull request Oct 8, 2019
Merged
7 tasks
@SamKirkland
Copy link

@zombieJ and @sooth-sayer
With the release of v4 what are the next steps for this?

@zombieJ
Copy link
Member

zombieJ commented Mar 9, 2020

Resolve the conflict and going on~

@afc163 afc163 mentioned this pull request Mar 13, 2020
Closed
@afc163 afc163 mentioned this pull request Jun 15, 2020
Closed
1 task
@afc163
Copy link
Member

afc163 commented Jun 15, 2020

conflicted

@afc163 afc163 mentioned this pull request Feb 8, 2021
Closed
1 task
@afc163
Copy link
Member

afc163 commented Jul 9, 2021

@sooth-sayer Could you resolve conflicts?

@janryWang
Copy link

@afc163 看样子 @sooth-sayer 已经消失了，github完全不活跃，建议单独开个PR吧

@dchernyatiev
Merge branch 'master' of https://github.com/react-component/tooltip i…
e0c2c10 
…nto react-component-master

* 'master' of https://github.com/react-component/tooltip: (50 commits)
  5.1.1
  feat: Support zIndex (react-component#258)
  fix less import path (react-component#257)
  Update README.md (react-component#251)
  5.1.0
  feat: motion conig support
  docs: add dumi badge
  chore: use dumi (react-component#240)
  chore: use actions (react-component#241)
  5.0.2
  Bump np from 6.5.0 to 7.1.0 (react-component#237)
  Update Tooltip.tsx (react-component#235)
  Add react and react-dom as peer dependencies
  Bump typescript from 3.9.7 to 4.0.3 (react-component#225)
  5.0.1
  chore: Father config @babel/runtime
  5.0.0
  chore: Use rc-trigger@5.x
  4.2.2
  chore: fix allowSyntheticDefaultImports define
  ...
@dchernyatiev
Merge branch 'react-component-master'
77f061d 
* react-component-master: (50 commits)
  5.1.1
  feat: Support zIndex (react-component#258)
  fix less import path (react-component#257)
  Update README.md (react-component#251)
  5.1.0
  feat: motion conig support
  docs: add dumi badge
  chore: use dumi (react-component#240)
  chore: use actions (react-component#241)
  5.0.2
  Bump np from 6.5.0 to 7.1.0 (react-component#237)
  Update Tooltip.tsx (react-component#235)
  Add react and react-dom as peer dependencies
  Bump typescript from 3.9.7 to 4.0.3 (react-component#225)
  5.0.1
  chore: Father config @babel/runtime
  5.0.0
  chore: Use rc-trigger@5.x
  4.2.2
  chore: fix allowSyntheticDefaultImports define
  ...
@dchernyatiev
Remove unused code
1a05d17
@sooth-sayer
Copy link
Author

@sooth-sayer Could you resolve conflicts?

Done

afc163
afc163 reviewed Jul 19, 2021
View reviewed changes
src/Tooltip.tsx
arrowPlacement,
domRef.current.getRootDomNode(),
targetPlacement,
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use https://github.com/yiminghe/dom-align in antd.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #166 (10cbd30) into master (0bafe74) will decrease coverage by 55.03%.
The diff coverage is 13.11%.

❗ Current head 10cbd30 differs from pull request most recent head 1a05d17. Consider uploading reports for the commit 1a05d17 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #166       +/-   ##
===========================================
- Coverage   96.96%   41.93%   -55.04%     
===========================================
  Files           3        4        +1     
  Lines          33       93       +60     
  Branches       12       31       +19     
===========================================
+ Hits           32       39        +7     
- Misses          1       54       +53
Impacted Files Coverage Δ
src/util.tsx 0.00% <0.00%> (ø)
src/Tooltip.tsx 53.33% <22.85%> (-42.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bafe74...1a05d17. Read the comment docs.

@ilinalexgit
Copy link

@zombieJ, @afc163 Any update on this fix? Are you planing to merge this?

@adwydman
Copy link

Any updates? Would be nice to have this merged

@afc163
Copy link
Member

afc163 commented May 27, 2023

Auto arrow position has been supported in antd 5.x now! ant-design/ant-design#40632

See https://ant.design/components/tooltip#components-tooltip-demo-shift

@afc163 afc163 closed this May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@zombieJ zombieJ zombieJ left review comments

@bedakb bedakb bedakb left review comments

Assignees

@zombieJ zombieJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@sooth-sayer @afc163 @zombieJ @Smeky @bedakb @SamKirkland @janryWang @ilinalexgit @adwydman @dchernyatiev