Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix trigger type def #210

Merged
merged 2 commits into from Mar 11, 2020
Merged

fix: fix trigger type def #210

merged 2 commits into from Mar 11, 2020

Conversation

wzhudev
Copy link
Contributor

@wzhudev wzhudev commented Mar 9, 2020

trigger: ActionType => trigger: ActionType | ActionType[]

@vercel
Copy link

vercel bot commented Mar 9, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/tooltip/m3l3kbacc
✅ Preview: https://tooltip-git-fork-wendellhu95-trigger-type.react-component.now.sh

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #210 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files           3        3           
  Lines          25       25           
  Branches       10       10           
=======================================
  Hits           22       22           
  Misses          3        3           
Impacted Files Coverage Δ
src/Tooltip.tsx 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7778a26...f5b10f6. Read the comment docs.

@zombieJ zombieJ merged commit 35baaed into react-component:master Mar 11, 2020
@zombieJ
Copy link
Member

zombieJ commented Mar 11, 2020

children 不能是 ReactNode,Trigger 只接受唯一的 ReactElement 元素来绑定事件。children 的定义我回滚一下。

@zombieJ
Copy link
Member

zombieJ commented Mar 11, 2020

+ rc-tooltip@4.0.2

@wzhudev
Copy link
Contributor Author

wzhudev commented Mar 11, 2020

children 不能是 ReactNode,Trigger 只接受唯一的 ReactElement 元素来绑定事件。children 的定义我回滚一下。

OK 我之前看到 tooltip 和 antd 的定义有冲突,不知道怎么改了

@wzhudev wzhudev deleted the trigger-type branch March 11, 2020 14:50
shc023 pushed a commit to shc023/tooltip that referenced this pull request Jul 31, 2021
* ci: add github actions and remove travis ci

* ci: update needs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants