-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize node ancestor checks #84
Optimize node ancestor checks #84
Conversation
Eliminate String.split() and compare position strings directly. Gives huge performance boost when handling lots of nodes, e.g. https://react-component.github.io/tree-select/examples/big-data.html
e4e7fa2
to
0fb117a
Compare
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 81.86% 82.44% +0.58%
==========================================
Files 7 7
Lines 623 621 -2
Branches 195 194 -1
==========================================
+ Hits 510 512 +2
+ Misses 110 106 -4
Partials 3 3
Continue to review full report at Codecov.
|
Thanks! |
@yesmeck I see that a new version of tree component (v1.7.9) has already been uploaded to NPM. Could you, please, also release new tree-select component? |
Released 1.12.1 |
@yesmeck could you please, also bump |
|
Yes, Still, for some reason, the example page uses old Thus, I assume, the safest way would be to declare the minimum required version explicitly. |
I'v just updated the example pages. |
Eliminate String.split() and compare position strings directly.
Gives huge performance boost when handling lots of nodes, e.g.
https://react-component.github.io/tree-select/examples/big-data.html