Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: basic wheel support #211

Merged
merged 5 commits into from
Aug 16, 2023
Merged

chore: basic wheel support #211

merged 5 commits into from
Aug 16, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 16, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtual-list ❌ Failed (Inspect) Aug 16, 2023 0:30am

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #211 (5ecbbc5) into master (b458210) will decrease coverage by 0.37%.
Report is 1 commits behind head on master.
The diff coverage is 98.96%.

❗ Current head 5ecbbc5 differs from pull request most recent head db0b673. Consider uploading reports for the commit db0b673 to get more accurate results

@@             Coverage Diff             @@
##            master     #211      +/-   ##
===========================================
- Coverage   100.00%   99.63%   -0.37%     
===========================================
  Files           15       16       +1     
  Lines          478      543      +65     
  Branches        93      108      +15     
===========================================
+ Hits           478      541      +63     
- Misses           0        2       +2     
Files Changed Coverage Δ
src/ScrollBar.tsx 98.13% <98.07%> (-1.87%) ⬇️
src/Filler.tsx 100.00% <100.00%> (ø)
src/List.tsx 100.00% <100.00%> (ø)
src/hooks/useFrameWheel.ts 100.00% <100.00%> (ø)
src/utils/scrollbarUtil.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 1e88230 into master Aug 16, 2023
8 of 9 checks passed
@zombieJ zombieJ deleted the wheel branch August 16, 2023 12:32
@@ -14,6 +16,8 @@ import useFrameWheel from './hooks/useFrameWheel';
import useMobileTouchMove from './hooks/useMobileTouchMove';
import useOriginScroll from './hooks/useOriginScroll';
import useLayoutEffect from 'rc-util/lib/hooks/useLayoutEffect';
import { getSpinSize } from './utils/scrollbarUtil';
import { useEvent } from 'rc-util';
Copy link
Member

@afc163 afc163 Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"rc-util": "^5.15.0"

这个库依赖的 rc-util 的版本需要升级到 5.36.0 以上:react-component/util@25fd32b ,否则会引发 ant-design/ant-design#44271 报错。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants