Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace scroll logic with inner width #212

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 16, 2023

  • Filler 设置宽度为 scrollWidth 时会导致 sticky: right 无效。把它挪到里面的 Item 上做 margin 偏移以支持 sticky。
  • 支持 extraRender 将额外内容添加至滚动容器中。

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtual-list ❌ Failed (Inspect) Aug 17, 2023 2:45am

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #212 (3309564) into master (db4f5c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3309564 differs from pull request most recent head 6153e75. Consider uploading reports for the commit 6153e75 to get more accurate results

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          16       16           
  Lines         543      544    +1     
  Branches      108      108           
=======================================
+ Hits          541      542    +1     
  Misses          2        2           
Files Changed Coverage Δ
src/Filler.tsx 100.00% <100.00%> (ø)
src/List.tsx 100.00% <100.00%> (ø)
src/hooks/useChildren.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 81d3b2a into master Aug 17, 2023
8 of 9 checks passed
@zombieJ zombieJ deleted the scroll-margin branch August 17, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant