Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select initial fixture from remote renderers #1376

Merged
merged 2 commits into from
Feb 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { waitFor } from '@testing-library/dom';
import { FixtureList } from 'react-cosmos-shared2/renderer';
import { loadPlugins, resetPlugins } from 'react-plugin';
import {
mockNotifications,
mockRouter,
} from '../../../../testHelpers/pluginMocks';
import { mockRendererReady } from '../../testHelpers';

beforeEach(() => jest.isolateModules(() => require('../..')));

afterEach(resetPlugins);

const fixtureId = { path: 'ein.js' };
const fixtures: FixtureList = { [fixtureId.path]: { type: 'single' } };

function registerTestPlugins() {
const { selectFixture } = mockRouter({
getSelectedFixtureId: () => null,
});
mockNotifications();
return { selectFixture };
}

function loadTestPlugins() {
loadPlugins();
}

it('selects initial fixture', async () => {
const { selectFixture } = registerTestPlugins();

loadTestPlugins();
mockRendererReady('mockRendererId', fixtures, { path: 'ein.js' });

await waitFor(() =>
expect(selectFixture).toBeCalledWith(expect.any(Object), { path: 'ein.js' })
);
});
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
import {
FixtureId,
RendererId,
RendererReadyResponse,
} from 'react-cosmos-shared2/renderer';
import { NotificationsSpec } from '../../Notifications/public';
import { postSelectFixtureRequest } from '../shared/postRequest';
import { getSelectedFixtureId } from '../shared/router';
import { RendererCoreContext, State } from '../shared';
import { RouterSpec } from '../../Router/public';

export function receiveRendererReadyResponse(
context: RendererCoreContext,
{ payload }: RendererReadyResponse
) {
const { rendererId, fixtures } = payload;
const { rendererId, fixtures, initialFixtureId } = payload;
context.setState(stateUpdater, afterStateChanged);

function stateUpdater(prevState: State) {
Expand All @@ -30,11 +32,20 @@ export function receiveRendererReadyResponse(
}

function afterStateChanged() {
selectFixtureFromUrlParams(context, rendererId);
if (initialFixtureId) selectInitialFixture(context, initialFixtureId);
else selectFixtureFromUrlParams(context, rendererId);
notifyRendererConnection(context, rendererId);
}
}

function selectInitialFixture(
{ getMethodsOf }: RendererCoreContext,
fixtureId: FixtureId
) {
const router = getMethodsOf<RouterSpec>('router');
router.selectFixture(fixtureId);
}

function selectFixtureFromUrlParams(
context: RendererCoreContext,
rendererId: RendererId
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ import { getRendererCoreMethods } from '../../../testHelpers/pluginMocks';

export function createRendererReadyResponse(
rendererId: RendererId,
fixtures: FixtureList
fixtures: FixtureList,
initialFixtureId?: FixtureId
): RendererReadyResponse {
return {
type: 'rendererReady',
payload: {
rendererId,
fixtures,
initialFixtureId,
},
};
}
Expand Down Expand Up @@ -52,10 +54,11 @@ export function createFixtureStateChangeResponse(

export function mockRendererReady(
rendererId: RendererId,
fixtures: FixtureList
fixtures: FixtureList,
initialFixtureId?: FixtureId
) {
return getRendererCoreMethods().receiveResponse(
createRendererReadyResponse(rendererId, fixtures)
createRendererReadyResponse(rendererId, fixtures, initialFixtureId)
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
mockCore,
mockNotifications,
mockRendererCore,
mockRouter,
} from '../../../testHelpers/pluginMocks';
import { fakeFetchResponseStatus } from '../testHelpers/fetch';
import { getIframe } from '../testHelpers/iframe';
Expand All @@ -22,7 +21,6 @@ function registerTestPlugins() {
getWebRendererUrl: () => 'http://localhost:5000/_renderer.html',
});
mockRendererCore();
mockRouter();
}

function loadTestPlugins() {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
getRendererCoreContext,
mockCore,
mockRendererCore,
mockRouter,
} from '../../../testHelpers/pluginMocks';
import { fakeFetchResponseStatus } from '../testHelpers/fetch';
import { getIframe, mockIframeMessage } from '../testHelpers/iframe';
Expand Down Expand Up @@ -46,7 +45,6 @@ it('posts renderer request message to iframe', async () => {

it('sends renderer response message to renderer core', async () => {
mockRendererUrl();
mockRouter();
const { receiveResponse } = mockRendererCore();

loadTestPlugins();
Expand All @@ -59,7 +57,6 @@ it('sends renderer response message to renderer core', async () => {

it('makes connected renderer the primary renderer', async () => {
mockRendererUrl();
mockRouter();
const { selectPrimaryRenderer } = mockRendererCore();

loadTestPlugins();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import React from 'react';
import { waitFor } from '@testing-library/dom';
import { render } from '@testing-library/react';
import React from 'react';
import { loadPlugins, resetPlugins, Slot } from 'react-plugin';
import { loadPlugins, Slot, resetPlugins } from 'react-plugin';
import {
getRendererPreviewMethods,
mockCore,
mockRendererCore,
mockRouter,
getRendererPreviewMethods,
} from '../../../testHelpers/pluginMocks';
import { fakeFetchResponseStatus } from '../testHelpers/fetch';
import { rendererErrorMsg, rendererReadyMsg } from '../testHelpers/messages';
import { rendererReadyMsg, rendererErrorMsg } from '../testHelpers/messages';

beforeEach(() => jest.isolateModules(() => require('..')));

Expand All @@ -20,7 +19,6 @@ function registerTestPlugins() {
getWebRendererUrl: () => 'mockRendererUrl',
});
mockRendererCore();
mockRouter();
}

function loadTestPlugins() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { loadPlugins, resetPlugins, Slot } from 'react-plugin';
import {
getRendererPreviewMethods,
mockCore,
mockRouter,
} from '../../../testHelpers/pluginMocks';
import { fakeFetchResponseStatus } from '../testHelpers/fetch';

Expand All @@ -17,7 +16,6 @@ function registerTestPlugins() {
mockCore({
getWebRendererUrl: () => 'mockRendererUrl',
});
mockRouter();
}

function loadTestPlugins(status: number) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { RendererResponse } from 'react-cosmos-shared2/renderer';
import { RendererCoreSpec } from '../RendererCore/public';
import { RouterSpec } from '../Router/public';
import { RendererPreviewContext } from './shared';

type WindowMsg = { data: { [key: string]: unknown } };
Expand All @@ -20,19 +19,14 @@ function createMessageHandler(context: RendererPreviewContext) {
return;
}

const router = context.getMethodsOf<RouterSpec>('router');
const rendererCore = context.getMethodsOf<RendererCoreSpec>('rendererCore');
const response = msg.data as RendererResponse;
rendererCore.receiveResponse(response);

updateRuntimeStatus(context, response);

if (response.type === 'rendererReady') {
const { rendererId, initialFixtureId } = response.payload;
rendererCore.selectPrimaryRenderer(rendererId);
if (initialFixtureId) {
router.selectFixture(initialFixtureId);
}
rendererCore.selectPrimaryRenderer(response.payload.rendererId);
}
};
}
Expand Down