Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add field in config for find-fixture-files (#687) #689

Merged
merged 1 commit into from May 24, 2018
Merged

feat: Add field in config for find-fixture-files (#687) #689

merged 1 commit into from May 24, 2018

Conversation

mpachin
Copy link
Contributor

@mpachin mpachin commented May 23, 2018

Fixes #687

@ovidiuch
Copy link
Member

This is great!

I only have two mentions:

  1. I appreciate the detailed README, but I'm afraid your scenario is too specific for the main README (it's already huge...). If you think it's valuable, you can move everything from "If your projects directory tree looks like this:" to a separate md file in the docs dir and link to it. Another option is to link to Add field in config for find-fixture-files method #687 as an example of where fileMatchIgnore can be useful.
  2. This is a pet peeve of mine and I apologize if it comes off annoying. I noticed you've always kept fileMatch, exclude and fileMatchIgnore in the same order, which is cool. But can you change the order as follows please? fileMatch, fileMatchIgnore and exclude. I find this makes more sense since fileMatchIgnore comes in effect before exclude and it looks better visually for fileMatch* options to be grouped.

Thanks!

@mpachin
Copy link
Contributor Author

mpachin commented May 24, 2018

Corrected 😊

@ovidiuch ovidiuch merged commit e70ef0f into react-cosmos:master May 24, 2018
@ovidiuch
Copy link
Member

@mpachin Please test your new option on 4.4.0! 🎉

@mpachin
Copy link
Contributor Author

mpachin commented May 25, 2018

@skidding just checked it in my project, everything works! 😃✨

@mpachin mpachin deleted the config-field-find-fixture branch May 25, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants