Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day selection not accessible with keyboard in Edge #1502

Open
terjela opened this issue Jan 9, 2019 · 4 comments
Open

Day selection not accessible with keyboard in Edge #1502

terjela opened this issue Jan 9, 2019 · 4 comments
Labels
accessibility Anything related to ensuring *everybody* can use react-dates <3 bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D

Comments

@terjela
Copy link

terjela commented Jan 9, 2019

react-dates version
react-dates@18.3.1

Describe the bug
It is not possible to navigate the day selection using the keyboard in Edge.

Screenshots/Gifs
singledatepicker

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Edge
  • Version 42.17134.1.0

Is the issue reproducible in Storybook?
SingleDatePicker

@ljharb ljharb added bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D accessibility Anything related to ensuring *everybody* can use react-dates <3 labels Jan 9, 2019
@majapw
Copy link
Collaborator

majapw commented Jan 9, 2019

I will take a look at this this week. That's a pretty serious bug! D:

@MM422
Copy link

MM422 commented Jan 17, 2019

@majapw Hi, I am just curious, since I am also using this library in my side project. I do realize that Keyboard navigation is not functional as well (Chrome 69 on Win10 machine). Can you confirm with that?

@eiriks
Copy link

eiriks commented Apr 8, 2019

@majapw Hey. Did you get around to take a look at this?

@backwardok
Copy link
Contributor

backwardok commented Apr 10, 2019

I tested this on Edge on a Windows machine in the latest version, and am not seeing the issue anymore. I also noticed that in 18.4.1, there was a change to make the inputs tabbable (#1499). There is a flicker issue (#1523) that that PR introduced, with an open PR (#1553) to address that. Would recommend upgrading to the latest version (or waiting until that PR gets merged and a new release gets out if you are holding out on the flicker behavior) to address this issue (though the flicker shouldn't affect your specific use case cause it's only for the date range picker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Anything related to ensuring *everybody* can use react-dates <3 bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Development

No branches or pull requests

6 participants