Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally use PureComponent instead of Component #1335

Merged
merged 7 commits into from
Sep 4, 2018
Merged

Conditionally use PureComponent instead of Component #1335

merged 7 commits into from
Sep 4, 2018

Commits on Aug 30, 2018

  1. Working to resolve react-dates#1297. Conditionally using `React.PureC… 

    …omponent` instead of `React.Component`
    Joseph Cota committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    e362c8e View commit details
    Browse the repository at this point in the history

  2. Making requested changes... 

      - Both `pureComponentAvailable` and `baseClass` are now functions
  - Using `extends baseClass()` instead of defining `BaseClass = baseClass()`
  - Fixing the lint on `DayPickerRangeController` for `pureComponentAvailable` being defined but not used
    Joseph Cota committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    1935ac0 View commit details
    Browse the repository at this point in the history

  3. Adding JSDOC to allow eslint to properly apply the react component li… 

    …nters.
    Joseph Cota committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    65cf032 View commit details
    Browse the repository at this point in the history

  4. Now both BaseClass and pureComponentAvailable are set at module l… 

    …oad, instead of using a function.
    Joseph Cota committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    a2fc9ac View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. Making requested change

    Joseph Cota committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    e230c61 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Updating the readme about overriding base class

    Joseph Cota committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    22c33ab View commit details
    Browse the repository at this point in the history

  2. couple of small tweaks.

    Joseph Cota committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    88fc16a View commit details
    Browse the repository at this point in the history