Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Clear Date for SingleDatePicker #155

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Show Clear Date for SingleDatePicker #155

merged 1 commit into from
Oct 31, 2016

Conversation

Mythra
Copy link
Contributor

@Mythra Mythra commented Oct 30, 2016

fixes #141

This PR adds in the ability to specify showClearDates for the SingleDatePicker which is showClearDates from DateRangePicker. The main goal here is obviously to create a button which allows the user to clear the date value inside of the SingleDatePicker.

The way I set this up should be mostly identical to DateRangePicker, really the only major thing I changes was changing the usage of the word "dates" to: "date" as it just seems to "fit better" ™️ . Needless to say the functionality of the button itself, as well as the reopen on clear feature should be completely identical. Just clearing the single date, instead of multiple dates.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 88.333% when pulling a1350be on SecurityInsanity:single_clear_date into da20c1f on airbnb:master.

Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thank you so much.

@majapw majapw merged commit 455fdef into react-dates:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showClearDate option for SingleDatePicker
3 participants