Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue where a system without autoprefixing will not allow for month transitions in safari #220

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Dec 19, 2016

Fixes #195

So I believe that adding this prefixes on the transition css prop should fix the issue @awhenderson was having where their implementation would not transition properly in Safari. I think that we have an autoprefixer at airbnb that automagically does this for us, but given that not everyone has this set-up, this should patch the problem for now.

@awhenderson let me know if this fixes your issue!

to: @airbnb/webinfra

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Dec 19, 2016
@majapw majapw requested a review from ljharb December 19, 2016 15:40
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.522% when pulling 8af45cc on maja-fix-no-transition-in-ios-8 into 08906d6 on master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should apply the autoprefixer in this repo if we can, even if it replaces the scss inline for the build

@majapw
Copy link
Collaborator Author

majapw commented Dec 19, 2016 via email

@majapw majapw merged commit 3f80429 into master Dec 20, 2016
@majapw majapw deleted the maja-fix-no-transition-in-ios-8 branch December 20, 2016 01:33
@lpk3nny
Copy link

lpk3nny commented Dec 20, 2016

-webkit-transition: -webkit-transform 0.2s ease-in-out;

@lpk3nny
Copy link

lpk3nny commented Dec 20, 2016

i mean, it will be fixed by autoprefixer of course, but in this quick fix u need to use prefixed transform

@alfonsogrondo
Copy link

Thanks @majapw, @ljharb, @lpk3nny tried prefixed transform and no change in problem for me, is it worth trying an autoprefixer tool? Any node package recommendations?

@alfonsogrondo
Copy link

Disregard my last comment - now working for me.

Thanks @majapw, @ljharb, @lpk3nny

@majapw
Copy link
Collaborator Author

majapw commented Dec 20, 2016

Jokes @lpk3nny is right. The transition is not the problem so much as the transform. I will update that. Will make that change.

@majapw
Copy link
Collaborator Author

majapw commented Dec 20, 2016

Did it in 92c2cfd. Going to do a new release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker not working correctly on iOS8 iPad iPhone
5 participants