build: add sass package for storybook #2231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sass package is needed to run storybook. while it's not listed in package.json we need to install it manually. this commit adds sass package in package.json #2204
ghost
mentioned this pull request
ledenis
reviewed
Aug 4, 2023
| @@ -129,7 +129,8 @@ | |||
| "react-portal": "^4.2.1", | |||
| "react-with-direction": "^1.4.0", | |||
| "react-with-styles": "~4.1.0", | |||
| "react-with-styles-interface-css": "^6.0.0" | |||
| "react-with-styles-interface-css": "^6.0.0", | |||
| "sass": "^1.62.0" | |||
There was a problem hiding this comment.
Shouldn't it be in devDependencies? Consumers of react-dates don't need sass, do they?
ljharb
requested changes
Aug 4, 2023
ghost
closed this by deleting the head repository
|
I guess @lukaonik deleted their account. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass package is needed to run storybook. while it's not listed in package.json we need to install it manually. this commit adds sass package in package.json
#2204