Clean up prop types definitions for top-level components #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-major: breaking change
lencioni
approved these changes
Feb 16, 2017
| import { START_DATE, END_DATE, HORIZONTAL_ORIENTATION, ANCHOR_LEFT } from '../constants'; | ||
| import isInclusivelyAfterDay from '../src/utils/isInclusivelyAfterDay'; | ||
|
|
||
| const propTypes = omit(DateRangePickerShape, [ |
There was a problem hiding this comment.
You could use object rest here instead of omit and avoid the dependency,
There was a problem hiding this comment.
It's a dev dependency so I didn't think it was a big deal. Doesn't using object rest require unused vars to be ignored?
- Make `onDate(s)Change` and `onFocusChange` required - Sort `DateRangePicker`, `SingleDatePicker`, `DayPicker` by category with comments - Use `forbidExtraProps` on all components - Add propTypes and defaultProps to the examples so that information shows up in the info addon
majapw
force-pushed
the
maja-make-required-props-actually-required
branch
from
da33d60
to
064c5af
Compare
|
|
|
Sweet. I'll add that in. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following
onDate(s)ChangeandonFocusChangerequiredDateRangePicker,SingleDatePicker,DayPickerby category with commentsforbidExtraPropson all componentsI would like ideally to have
focusedInput/startDate/endDateandfocused/dateto be required as well, but since those can take a value ofnullthat's a bit trickier. I might make a validator that allows for this (something likeisDefined).to: @airbnb/webinfra