Skip to content
This repository has been archived by the owner on Jun 18, 2018. It is now read-only.

Add HTML type #1

Closed
wants to merge 2 commits into from
Closed

Add HTML type #1

wants to merge 2 commits into from

Conversation

mattlenz
Copy link

This pull request adds support for the text/html type.

@gaearon
Copy link
Member

gaearon commented Oct 23, 2015

Please test this change on the examples in React DnD repo.
You can run

npm install
npm start

and then open http://localhost:8080 and go through the examples.

@gaearon
Copy link
Member

gaearon commented Dec 25, 2015

This breaks the examples using URLs because HTML type wins.
I don't think we can take it without significantly changing how native types are handled.

We need to either start treating them as the same type, figure out a way to support many times in a nice way, or make native type configuration injectable so apps can choose what they care about. I'm going to close this PR because it doesn't address this bigger issue, but feel free to maintain a fork or propose an API for handling these cases.

@gaearon gaearon closed this Dec 25, 2015
danii1 pushed a commit to danii1/react-dnd-html5-backend that referenced this pull request Aug 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants