Disable browser fixes when mixin is inactive

This prevents false positives when `dragover` and `drop` aren't caused by mixin, for example when dragging files over the browser window.
react-dnd · Oct 23, 2014 · 48b2ba8 · 48b2ba8
1 parent 8060c8a
commit 48b2ba8
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/modules/mixins/DragDropMixin.js b/modules/mixins/DragDropMixin.js
@@ -186,7 +186,7 @@ function resetGlobalDragState() {
 
 if (isWebkit()) {
   window.addEventListener('dragover', function (e) {
-    if (checkIfCurrentDragTargetRectChanged()) {
+    if (_currentDragTarget && checkIfCurrentDragTargetRectChanged()) {
       // Prevent animating to incorrect position
       e.preventDefault();
     }
@@ -198,8 +198,8 @@ if (isWebkit()) {
  * We will attempt to fire it ourselves when global `drop` occurs.
  */
 function triggerDragEndIfDragSourceWasRemovedFromDOM() {
-  if (_handleCurrentDragEnd &&
-      _currentDragTarget &&
+  if (_currentDragTarget &&
+      _handleCurrentDragEnd &&
       !document.contains(_currentDragTarget)) {
 
     _handleCurrentDragEnd();
@@ -218,6 +218,10 @@ if (!isFirefox()) {
   var _lastDragSourceCheckTimeout = null;
 
   window.addEventListener('dragover', function () {
+    if (!_currentDragTarget) {
+      return;
+    }
+
     clearTimeout(_lastDragSourceCheckTimeout);
 
     _lastDragSourceCheckTimeout = setTimeout(
@@ -479,4 +483,4 @@ var DragDropMixin = {
   }
 };
 
-module.exports = DragDropMixin;
+module.exports = DragDropMixin;