Fix for drag in scrolling container: set dropEffect to 'none' when canDrop is false #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depend on drag source rect (if drag source position has changed, dropEffect should be 'none' when drop is disabled).
darthtrevino
approved these changes
Nov 5, 2018
darthtrevino
pushed a commit
that referenced
this pull request
Feb 3, 2022
…nDrop is false (#1131) * Set dropEffect to 'none' when canDrop is false. dropEffect should not depend on drag source rect (if drag source position has changed, dropEffect should be 'none' when drop is disabled). * Remove unused code (we don't need to get/compare currentDragSourceNodeOffset anymore) * revert lodash change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dragging in scrolling container, drag cursor resets to 'move' after any scrolling because of this strange code
Because of this, after scroll, drag cursor on drop targets, disabled for drop (or non-drop target elements) is shown as 'move' cursor, whereas it should be shown as 'disabled' cursor, because drop is disabled by application logic.
This behavior is very confusing for users.