Fix tutorial code snippets #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: `Cannot have two HTML5 backends at the same time.`
|
LGTM, I think we'll want to eventually make this more idiomatic (e.g. renderSquare is really a Function component, handleSquareClick should be a callback hook). |
darthtrevino
pushed a commit
that referenced
this pull request
Feb 3, 2022
* Fix tutorial code snippets * Fix onClick handler example * Use handleSquareClick as a regular function * Fix renderPiece function in tutorial * Fix DragDropContext usage Fixes: `Cannot have two HTML5 backends at the same time.` * Fix renderOverlay usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the tutorial and noticed a few bugs in the code snippets. This PR aims to fix them.
Changes are:
Boardshould not reference helper functions viathissince it is an SFC.handleSquareClick,renderPieceandrenderOverlayas a static function to be consistent with the previous example whererenderSquarewas introduced as a static function.DragDropContextHOC instead ofDragDropContextProviderto avoidCannot have two HTML5 backends at the same time.error.