Remove useless constraint #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing microsoft/TypeScript#30634 will make this constraint fail to check for most users - this type seems to have been copied from (to?) `react-redux`, which has taken in a similar change on DT: DefinitelyTyped/DefinitelyTyped#34335 DefinitelyTyped/DefinitelyTyped#34339
|
I did copy the structure here from react-redux. Thanks for the pr! |
darthtrevino
approved these changes
Mar 31, 2019
darthtrevino
pushed a commit
that referenced
this pull request
Feb 3, 2022
Fixing microsoft/TypeScript#30634 will make this constraint fail to check for most users - this type seems to have been copied from (to?) `react-redux`, which has taken in a similar change on DT: DefinitelyTyped/DefinitelyTyped#34335 DefinitelyTyped/DefinitelyTyped#34339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while testing DefinitelyTyped against microsoft/TypeScript#30637.
Fixing microsoft/TypeScript#30634 will make this constraint fail to check for most users - this type seems to have been copied from (to?)
react-redux, which has taken in a similar change on DT:DefinitelyTyped/DefinitelyTyped#34335
DefinitelyTyped/DefinitelyTyped#34339
The constraint on
DecorationTargetPropswas circularly defined anyway so despite not having an error (due to deferral in the mapped type ofShared), it never actually had an effective constraint.