Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style of sources disagrees with .editorconfig #1356

Closed
upsuper opened this issue May 27, 2019 · 0 comments · Fixed by #1358
Closed

Code style of sources disagrees with .editorconfig #1356

upsuper opened this issue May 27, 2019 · 0 comments · Fixed by #1358

Comments

@upsuper
Copy link
Contributor

upsuper commented May 27, 2019

The .editorconfig in the repo root says

indent_style = space
indent_size = 2

However, as far as I can see, at least TypeScript files in packages/react-dnd/src use tab for indent.

That makes editors which recognize .editorconfig use inconsistent code style when editing such files. This is confusing.

Should .editorconfig be updated to match source code, or should the source code be updated to match .editorconfig?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove .editorconfig file react-dnd/react-dnd
1 participant
@upsuper