v8: Move Decorators into a new Package #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthtrevino
added a commit
that referenced
this pull request
Jun 14, 2019
* docs: use hooks-based examples in code-sandboxes * refactor: move decorator-based API to a new package (#1382) * docs: correct docsite loading * Consolidate builds into ES-Modules (#1383) * refactor: remove cjs builds * fix: update tsconfigs * refactor: replace require() form with imports. use @ts-ignore if types are unavailable * refactor: remove umd builds * refactor: remove webpack deps from react-dnd-html5-backend * refactor: update how internals are shared between react-dnd and react-dnd-decorators * fix: correct tests * fix: jest typings issues * Move Decorators back into React-DnD (#1392) * refactor: move decorators back to the main library * fix: add type: module to package.json files * chore: remove wallaby.js file * Restore UMD Builds as a new Package (#1393) * build: add umd builds package * feat: restore umd builds in a separate package * test: add test.html driver * docs: allow examples to swap between hooks and decorator mode * docs: style the hooks/decorators toggle * docs: add hooks/decorator example sandboxes * docs: remove mention of the ?legacy flag * fix: remove mention of react-dnd-decorators * docs: correct examples import * docs: use hooks on docsroot
darthtrevino
added a commit
that referenced
this pull request
Feb 3, 2022
* docs: use hooks-based examples in code-sandboxes * refactor: move decorator-based API to a new package (#1382) * docs: correct docsite loading * Consolidate builds into ES-Modules (#1383) * refactor: remove cjs builds * fix: update tsconfigs * refactor: replace require() form with imports. use @ts-ignore if types are unavailable * refactor: remove umd builds * refactor: remove webpack deps from react-dnd-html5-backend * refactor: update how internals are shared between react-dnd and react-dnd-decorators * fix: correct tests * fix: jest typings issues * Move Decorators back into React-DnD (#1392) * refactor: move decorators back to the main library * fix: add type: module to package.json files * chore: remove wallaby.js file * Restore UMD Builds as a new Package (#1393) * build: add umd builds package * feat: restore umd builds in a separate package * test: add test.html driver * docs: allow examples to swap between hooks and decorator mode * docs: style the hooks/decorators toggle * docs: add hooks/decorator example sandboxes * docs: remove mention of the ?legacy flag * fix: remove mention of react-dnd-decorators * docs: correct examples import * docs: use hooks on docsroot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the decorator API into a new package: react-dnd-decorators. The decorator API is complex and fragile. This isolates the decorator-based code and encourages users to use the hooks-based API as normative.