Fix inaccurate position with custom drag layers #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthtrevino
approved these changes
Oct 25, 2020
Codecov Report
@@ Coverage Diff @@
## main #2818 +/- ##
==========================================
+ Coverage 52.47% 52.49% +0.02%
==========================================
Files 87 87
Lines 2544 2543 -1
Branches 472 473 +1
==========================================
Hits 1335 1335
+ Misses 1209 1208 -1
|
This was referenced Mar 15, 2021
darthtrevino
added a commit
that referenced
this pull request
Feb 3, 2022
* fix: correct issue with `dragenter` being fired with no actual target * chore: cut semver document Co-authored-by: Eric Fleury <fleury@capintel.ca> Co-authored-by: Chris Trevino <chtrevin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2638
Fixes an issue where the dragenter gets fired with no target, resulting in a wrong position for the drag preview. The fix had already been patched for FF only, but turned out to be reproducible on Chrome and Edge as well.