Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Chess Example Tests from PR #3025

Merged
merged 3 commits into from Feb 11, 2021
Merged

Migrate Chess Example Tests from PR #3025

merged 3 commits into from Feb 11, 2021

Conversation

darthtrevino
Copy link
Member

@darthtrevino darthtrevino commented Feb 11, 2021

Thanks @ryota-murakami, these tests are much clearer to read and author than what we have using the react-dnd-test-backend and react-dnd-test-utils packages. I love how easy it is to declare drag/drop interactions using the testing-library API.

Adapted tests from #2733

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #3025 (8158d6a) into main (d12b62d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3025   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files          79       79           
  Lines        2290     2290           
  Branches      500      500           
=======================================
  Hits         1193     1193           
  Misses       1097     1097           

@darthtrevino darthtrevino merged commit 7a89d46 into main Feb 11, 2021
@darthtrevino darthtrevino deleted the test/add_chess_tests branch February 11, 2021 06:20
@ryota-murakami
Copy link

@darthtrevino That's great!
I'm glad to improved official testing example as a result.

Thank you tell me about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants