Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Examples Packages in Test Coverage #3037

Merged
merged 5 commits into from Feb 18, 2021
Merged

Conversation

darthtrevino
Copy link
Member

The previous philosophy of react-dnd has been to apply test coverage to the primary libraries.

By applying test coverage to the examples, we can make this metric reflect the overall testability of the system and understand the testing implications better for clients.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #3037 (5c1531d) into main (2ba22bf) will decrease coverage by 11.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3037       +/-   ##
===========================================
- Coverage   52.09%   40.81%   -11.29%     
===========================================
  Files          79      253      +174     
  Lines        2290     3788     +1498     
  Branches      500      768      +268     
===========================================
+ Hits         1193     1546      +353     
- Misses       1097     2241     +1144     
- Partials        0        1        +1     
Impacted Files Coverage Δ
...ples-hooks/src/01-dustbin/multiple-targets/Box.tsx 100.00% <0.00%> (ø)
packages/examples-decorators/src/index.ts 0.00% <0.00%> (ø)
...c/07-regression/drag-source-rerender/Container.tsx 0.00% <0.00%> (ø)
...ples-hooks/src/03-nesting/drop-targets/Dustbin.tsx 0.00% <0.00%> (ø)
...rators/src/01-dustbin/multiple-targets/Dustbin.tsx 78.94% <0.00%> (ø)
...regression/remount-with-correct-props/ItemTypes.ts 0.00% <0.00%> (ø)
...egression/remount-with-correct-props/TargetBox.tsx 0.00% <0.00%> (ø)
...examples-hooks/src/04-sortable/simple/ItemTypes.ts 0.00% <0.00%> (ø)
.../examples-decorators/src/00-chessboard/Overlay.tsx 81.81% <0.00%> (ø)
...decorators/src/06-other/native-files/Container.tsx 0.00% <0.00%> (ø)
... and 164 more

@darthtrevino darthtrevino merged commit 120a6bf into main Feb 18, 2021
@darthtrevino darthtrevino deleted the test/add_more_tests branch February 18, 2021 17:35
darthtrevino added a commit that referenced this pull request Feb 3, 2022
* chore: upgrade dependencies

* test: include examples packages in coverage determination

* chore: cut semver

* chore: update semver

* chore: update yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant