Pass offsetX and offsetY as createDragPreview options to force offsets #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any news on this? this looks very useful and i'm currently needing this, is there anything that i can do to help to land this feature? |
|
Still no news. I had to fork the repo and use my version. |
|
@darthtrevino Maybe this PR can be merge? |
darthtrevino
requested changes
Jun 11, 2017
| @@ -314,15 +314,21 @@ export default class HTML5Backend { | |||
| const sourceId = this.monitor.getSourceId(); | |||
| const sourceNode = this.sourceNodes[sourceId]; | |||
| const dragPreview = this.sourcePreviewNodes[sourceId] || sourceNode; | |||
| const { anchorX, anchorY } = this.getCurrentSourcePreviewNodeOptions(); | |||
| const { anchorX, anchorY, offsetX, offsetY } = this.getCurrentSourcePreviewNodeOptions(); | |||
There was a problem hiding this comment.
I think we should pass in the the offsetX and offsetY as an additional argument to getDragPreviewOffset
(offsetPoint) instead of doing the computation here.
There was a problem hiding this comment.
Ok, i did the changes, offsets are now pass as an additional argument to getDragPreviewOffset.
I choosed to not optimize the method and even if offsets are forced the function still calculate the interpolated offsets.
I didn't want to take any risk to break this part.
darthtrevino
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two optionals fields (offsetX and offsetY) to createDragPreview options.
Those fields allow to force specific offsets values.
Linked to #775