Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome 63 hangs dragging a file onto the drop zone whilst the file dialog is open. #549

Closed
1 of 2 tasks
dennisroche opened this issue Jan 9, 2018 · 3 comments
Closed
1 of 2 tasks

Chrome 63 hangs dragging a file onto the drop zone whilst the file dialog is open. #549

dennisroche opened this issue Jan 9, 2018 · 3 comments

Comments

@dennisroche
Copy link
Contributor

dennisroche commented Jan 9, 2018 •
edited

Do you want to request a feature or report a bug?

  • I found a bug
  • I want to propose a feature

What is the current behavior?

Chrome 63 hangs dragging a file onto the drop zone whilst the file dialog is open.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Go to https://react-dropzone.js.org/ and use the 'Basic example'.
  2. Click the drop zone to open the file dialog.
  3. Drag a single file from the file dialog into the drop zone.
    • The file dialog doesn't close
    • Doesn't crash when dragging multiple files
  4. Open or cancel the file dialog. Chrome crashes 💥.

What is the expected behavior?

The drop zone shouldn't accept a file being dropped whilst the file dialog is open.

Please mention other relevant information such as the browser version, Operating System and react-dropzone version.

react-dropzone 4.2.3
chrome 63.0.3239.132
windows 10 (1709)
@okonet
Copy link
Collaborator

okonet commented Jan 9, 2018

I’d be happy to merge your fix!

@dennisroche dennisroche changed the title Chrome 63 hangs dragging a file **when** a file is dropped whilst the file dialog is open. Chrome 63 hangs dragging a file **when** whilst the file dialog is open. Jan 10, 2018
@dennisroche dennisroche changed the title Chrome 63 hangs dragging a file **when** whilst the file dialog is open. Chrome 63 hangs dragging a file onto the drop zone whilst the file dialog is open. Jan 10, 2018
@dennisroche dennisroche mentioned this issue Jan 10, 2018
Merged
9 tasks
@dennisroche
Copy link
Contributor Author

PR up. 👍

okonet pushed a commit that referenced this issue Jan 11, 2018
@okonet
fix: Chrome 63 hangs dragging a file onto the drop zone whilst the fi…
70ac399 
…le dialog is open (#549)
@SourceCipher SourceCipher mentioned this issue Jan 12, 2018
Closed
2 tasks
@okonet okonet closed this as completed Jan 12, 2018
@okonet
Copy link
Collaborator

okonet commented Jan 12, 2018

Fixed in #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okonet @dennisroche