Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed onFileDialogCancel listener overwritting by each instance #611

Merged
merged 2 commits into from
May 22, 2018

Conversation

koretskiyav
Copy link
Contributor

@koretskiyav koretskiyav commented May 22, 2018

What kind of change does this PR introduce?

  • bugfix
  • feature
  • refactoring / style
  • build / chore
  • documentation

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary

Fixes #575

Does this PR introduce a breaking change?

Other information

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #611 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   99.02%   99.01%   -0.01%     
==========================================
  Files           3        3              
  Lines         205      204       -1     
  Branches       60       59       -1     
==========================================
- Hits          203      202       -1     
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 99.41% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72abe1d...a0ae02f. Read the comment docs.

@okonet okonet self-requested a review May 22, 2018 18:29
@okonet
Copy link
Collaborator

okonet commented May 22, 2018

Great work! Thanks for fixing it!

@okonet
Copy link
Collaborator

okonet commented May 22, 2018

@koretskiyav could you please take a look if #557 is related to this? Also, would be great if you could fill out the summary for the PR.

Thanks!

@okonet okonet merged commit afaf401 into react-dropzone:master May 22, 2018
@koretskiyav
Copy link
Contributor Author

@okonet I can not reproduce this problem myself, both before this fix and after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onFileDialogCancel doesn't seem to be firing.
2 participants