Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check drag event contains files before showing "copy" cursor #1053

Merged
merged 1 commit into from Mar 26, 2021

Conversation

tommoor
Copy link
Contributor

@tommoor tommoor commented Mar 19, 2021

What kind of change does this PR introduce?

  • bugfix
  • feature
  • refactoring / style
  • build / chore
  • documentation

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary

A green "plus" symbol shows when dragging links and other non-file items across a dropzone. This is particularly noticable if you combine react-dropzone with a draggable library like react-dnd, but it's also noticeable in the examples even in the docs.

closes #1042

@coveralls
Copy link

coveralls commented Mar 19, 2021

Pull Request Test Coverage Report for Build 63b7ff8ce2c291b23223782937ccca394ababec9-PR-1053

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 99.735%

Totals Coverage Status
Change from base Build 6f0e826f6337367ab8b47efaa04449d839594c2a: 0.3%
Covered Lines: 205
Relevant Lines: 205

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 63b7ff8ce2c291b23223782937ccca394ababec9-PR-1053

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 99.735%

Totals Coverage Status
Change from base Build 6f0e826f6337367ab8b47efaa04449d839594c2a: 0.3%
Covered Lines: 205
Relevant Lines: 205

💛 - Coveralls

@rolandjitsu rolandjitsu merged commit ec93425 into react-dropzone:master Mar 26, 2021
@github-actions
Copy link

🎉 This PR is included in version 11.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants