Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General project refactor #60

Merged
merged 81 commits into from
Apr 11, 2019
Merged

General project refactor #60

merged 81 commits into from
Apr 11, 2019

Conversation

piranna
Copy link
Collaborator

@piranna piranna commented Apr 14, 2018

This pull-request acomplish several things:

  • Checked and ensured re-base template generates a project that works untouched on Android, web and Electron (should work on iOS, but I can't be able to test it)
  • Removed useless or duplicated files from re-base template to make it as minimal and out-of-the-way as possible
  • Fixed templates placeholders so project name gets correctly filled everywhere
  • Added build scripts for all platforms to package.json, so there's no need to learn external tools, everything can be build with npm run <platform> and npm run <platform>:release.
  • Layered architecture so several templates can be applied ones on top of anothers to customize the scheleton created by re-base template (still untested, but should work)

piranna and others added 26 commits October 2, 2017 09:07
- Add all-contributors scripts
- bump version number
- update keywords
- General code clean-up
- Removal of useless or duplicated files and entrypoints
- Fixed URL for `electron` platform (use local filesystem one)
- Use of `react-native` template placeholders
- Higher resolution favicon image
- Extra `script` fields, all platforms can be build with `npm run <platform>`
- Removal of `additionalDependencies` file after they are installed
@piranna
Copy link
Collaborator Author

piranna commented Dec 21, 2018

Ok, so thanks to a current client interested on re-start, I've have time to review the refactor and finish it. The latest changes that I've done has been removal of setting devDepedencies since React Native CLI now has support for it, updated to Electron 4, and more important, I've been able to test and fix the layered templates, so now they are working correctly and we can start to create templates adjusted to our own needs. I could be able to merge it in master branch a version 0.4 but I don't have permissions to publish it on npm, so @amoghbanta, could you be able to take a look at the pull-request and publish it on npm? :-) By the moment they are published by myself as re-base_piranna and re-dux_piranna, but i would like to have it merged upstream...

@piranna piranna merged commit 530ff1f into react-everywhere:master Apr 11, 2019
re-base automation moved this from In progress to Done Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
re-base
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants