adding positionOffset prop to <Draggable/> #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops.. I just realized that you wanted the new prop to be called |
|
@STRML bump |
STRML
requested changes
Mar 25, 2019
|
@STRML I've made the changes you requested. Let me know if those check out! |
|
I was having trouble getting |
|
What were the errors? |
|
@STRML hmm it just worked with |
|
@STRML merge it? |
STRML
reviewed
Mar 26, 2019
| const translation = getTranslation(controlPos, positionOffset, ''); | ||
| return translation; | ||
| } | ||
| export function getTranslation({x, y}: ControlPosition, positionOffset: PositionOffsetControlPosition, unitSuffix: string): string { |
STRML
approved these changes
Mar 26, 2019
|
Lemme know when this gets released! Thanks @STRML |
|
@STRML will you please release a new version with this in it? Thank you :) |
|
Published as |
|
Thanks!!
…On Thu, Apr 18, 2019, 6:25 PM Samuel Reed ***@***.***> wrote:
Published as 3.3.0 @tnrich <https://github.com/tnrich>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#393 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAU2U4POD57RP2Q3JH7KTA3PRENPRANCNFSM4G4ZIVZA>
.
|
tnrich
changed the title
MaciejCzyzewsk
pushed a commit
to MaciejCzyzewsk/react-draggable
that referenced
this pull request
Feb 20, 2023
* adding initialPosition prop to <Draggable/> * changing initialPosition to positionOffset * fixing missed rename * Delete pnpm-debug.log * Delete package-lock.json * Delete shrinkwrap.yaml * making requested changes in react-grid-layout/react-draggable#393
ludarkhorse
added a commit
to ludarkhorse/ReactGrid
that referenced
this pull request
Feb 21, 2023
* adding initialPosition prop to <Draggable/> * changing initialPosition to positionOffset * fixing missed rename * Delete pnpm-debug.log * Delete package-lock.json * Delete shrinkwrap.yaml * making requested changes in react-grid-layout/react-draggable#393
Karasu0888
pushed a commit
to Karasu0888/react-draggable
that referenced
this pull request
Sep 12, 2023
* adding initialPosition prop to <Draggable/> * changing initialPosition to positionOffset * fixing missed rename * Delete pnpm-debug.log * Delete package-lock.json * Delete shrinkwrap.yaml * making requested changes in react-grid-layout/react-draggable#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @STRML, here is my first pass at allowing initial position to be a string percent. It is essentially using the same code as before but does not modify the defaultPosition prop in any way and instead adds a new initialPosition prop.
I think this is working as is. We should probably add a few more tests to be sure that the drag callbacks that broke last time aren't breaking this time.
connects #391