Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging not working #16

Closed
zoomclub opened this issue Jan 17, 2015 · 16 comments
Closed

Dragging not working #16

zoomclub opened this issue Jan 17, 2015 · 16 comments

Comments

@zoomclub
Copy link

Looks like another great React library! However, in the latest Chrome on OS X the dragging is not working, any idea why? If I try Packery or Gridster the dragging of items works as expected :)

@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

Hi @zoomclub, the dragging is working fine for me on Chrome 41 on OS X. Could you please check for errors in your console?

@zoomclub
Copy link
Author

With an up to date Chrome 40.0.2214.85 beta (64-bit) I get the following console message:

console

@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

That's strange. Are you running the example locally (cloned repo and opening via file:// url) or just viewing the demo at https://strml.github.io/react-grid-layout/examples/1-basic.html ?

@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

I've just repushed the gh-pages branch with minification turned off and source maps on, could you repost your console?

@zoomclub
Copy link
Author

I'm just running the demo online. Here is the console message now:

console2

@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

Cool, thanks, that's much better. I'll see what I can do. It appears to be a bug in our dependency react-draggable.

@STRML STRML closed this as completed Jan 17, 2015
@STRML STRML reopened this Jan 17, 2015
@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

@zoomclub Could you retry and verify this is fixed?

@zoomclub
Copy link
Author

Dragging a complete box/div does not work on the laptop and gives no error, while it drags nicely on the iPad. When dragging on the corner resize icon it still gives an error on the laptop, I've included the error message below in case it involves other dependables. Is the demo/API only meant for the mobile touch devices or can I also drag on the laptop in the usual point, click and drag way?

It would be most excellent if PointerEvents were embraced by all browsers already, its basically something that should of happened last year, meanwhile they are still putting up a fuss about it, at least Google is :)

console3

@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

I've run the demo on my machine (Chrome 41 OS X) both in normal and touch-screen emulation mode and both are working.

It's intended that demo works both in touch and non-touch environments.

I've just pushed an update to the demo - the reason you were seeing the error on the resizable handle was because both RGL & react-resizable depend on react-draggable, and when I built the bundle I forgot to update react-resizable's dep.

It should work for you now in all envs.

@zoomclub
Copy link
Author

Just cleared cached files and images and restarted Chrome then tried again. Chrome extension settings are in developer mode but I presently have none of the extensions enabled.

After several tries it looks like the dragging of items does not work for me in Chrome. However, it does work in Safari. Whats up with Chrome?

@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

No idea, it is working for me in v41.
On Jan 17, 2015 9:42 PM, "zoomclub" notifications@github.com wrote:

Just cleared cached files and images and restarted Chrome then tried
again. Chrome extension settings are in developer mode but I presently have
none of the extensions enabled.

After several tries it looks like the dragging of items does not work for
me in Chrome. However, it does work in Safari. Whats up with Chrome?


Reply to this email directly or view it on GitHub
#16 (comment)
.

@zoomclub
Copy link
Author

Dragging and resizing works fine in Chrome Canary too but still not in the standard Chrome browser. Likely not but would any special Chrome flags need to be set?

@STRML
Copy link
Collaborator

STRML commented Jan 17, 2015

You might have some weird emulation setting on. Chrome shouldn't be
advertising touch capability to begin with.
On Jan 17, 2015 10:36 PM, "zoomclub" notifications@github.com wrote:

Dragging and resizing works fine in Chrome Canary too but still not in the
standard Chrome browser. Likely not but would any special Chrome flags need
to be set?


Reply to this email directly or view it on GitHub
#16 (comment)
.

@zoomclub
Copy link
Author

Instead of pecking through all Chrome flags I just reset all of them to default. It then works in standard Chrome. Who knows what the specific flag was, I had set a few for WebGL related projects. Thanks for the help and I'll look further into react-grid-layout next :)

@STRML
Copy link
Collaborator

STRML commented Jan 18, 2015

Okay great. Glad you got it working.

@STRML STRML closed this as completed Jan 18, 2015
mikepb pushed a commit to mikepb/react-draggable that referenced this issue Mar 2, 2015
@jacksontong
Copy link

I have a laptop with touch screen and I'm using react-grid-layout 0.8.5, I could use my finger to drag & drop, but I can't use my mouse to drag & drop, is there any way to work around with this?

MDev128 added a commit to MDev128/react-draggable that referenced this issue Aug 13, 2018
ludarkhorse added a commit to ludarkhorse/ReactGrid that referenced this issue Feb 21, 2023
wdavis122 added a commit to wdavis122/react-draggable that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants