Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Npm build - remove coverage folder (-60%size) - move eslint parser to devDependencies #1655

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

salvoravida
Copy link
Contributor

Hi guys,
First of all, I have to say thank you for this great library!

This PR fixes two small bugs on the Npm build side:

  • remove coverage folder (-60%size)
  • move "@babel/eslint-parser" to devDependencies.

Regards!

@salvoravida
Copy link
Contributor Author

@STRML
Copy link
Collaborator

STRML commented Jan 24, 2022

Thanks! These are bugs for sure so I'll do a point release to get this out ASAP and save some bytes.

@STRML STRML merged commit a40c8b8 into react-grid-layout:master Jan 24, 2022
@STRML
Copy link
Collaborator

STRML commented Jan 24, 2022

Thanks. Published in 1.3.3. Solid fix:

Before:

npm notice package size:  245.6 kB
npm notice unpacked size: 1.2 MB

After:

npm notice package size:  131.1 kB
npm notice unpacked size: 487.7 kB

@salvoravida
Copy link
Contributor Author

it also fixes a warning:
warning "react-grid-layout > @babel/eslint-parser@7.16.5" has unmet peer dependency "@babel/core@>=7.11.0".

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants