-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced window resize event handler with resizeObserver #1839
Conversation
…care of element resize
I'm not married to IE11 compatibility, but this will break it. What's the issue corresponding to this? |
Thank you for your response. I apologize for not creating an issue earlier. I will ensure to create one promptly to keep track of this. Regarding Pull Request #984, I believe your suggestion to use |
Please rebase this @currents-jantu and I will merge. |
Ok. This breaks tests due to the missing ResizeObserver global. I would prefer we use the |
Sure, it make sense |
@currents-jantu I am now realizing this broke the resize tests. Could you please fix it?
|
Sure, I will work on the test. |
@STRML current test cases won't work with |
I don't know how to fix it - really a question for you. For now I will remove the test on |
This is a known bug so, not creating an issue.
This changes makes this component to work with collapsible sidebar, basically it will takes care of RGL width change even if window is not resized