Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): revert fast-equals to @4.0.3 #1932

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

STRML
Copy link
Collaborator

@STRML STRML commented Sep 12, 2023

Description

This PR fixes #1904 by reverting fast-equals to @4, working around a Create-React-App@5 bug. facebook/create-react-app#11889

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

#1904

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ examples
  • πŸ™… no documentation needed

@STRML STRML merged commit 0656b14 into master Sep 12, 2023
2 checks passed
@STRML STRML deleted the fix/fast-equals-bug-1904 branch September 12, 2023 14:31
@github-actions
Copy link

Packj audit found 4/6 risky dependencies.

Click here for details

Registry Package Version Risks
npm clsx 2.0.0
npm fast-equals 4.0.3

undesirable

. Click for details
  • package is old or abandoned: 383 days old
  • invalid or no author email: no email
  • npm prop-types 15.8.1

    undesirable

    . Click for details
  • package is old or abandoned: 615 days old
  • npm react-draggable 4.4.5

    undesirable

    . Click for details
  • package is old or abandoned: 503 days old
  • invalid or no author email: no email
  • npm react-resizable 3.0.5
    npm resize-observer-polyfill 1.5.1

    undesirable

    . Click for details
  • package is old or abandoned: 1737 days old
  • Triggered by workflow run 51 on commit 61bf37100cde7520603e37df8223a1bbd5969412

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    (0 , _fastEquals.deepEqual) is not a function
    1 participant